better handling for skysat images #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
previously approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Just wanted to check to see if there should be any "reflectance" roles added per #78 (comment). If not, lgtm.
gadomski
dismissed
their stale review
Revoking the approval just to deal w/ the one question on "reflectance", will re-grant approval once that's cleared up.
|
@gadomski I forgot that. It should be already added |
gadomski
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR title is not accurate, this PR now contains a larger set of changes for the planet_item module.
This includes:
Fixing an issue when working with Skysat analytic images with a single band.
Correcting a problem with image dimensions, which were wrongly assigned
More robust creation of thumbnails
Better role assignmnent (fixes #78)