chore(NA): move kibana_legacy, saved_objects saved_objects_management…

… into lodash3

src/plugins/kibana_legacy/public/angular/angular_config.tsx

@@ -26,7 +26,7 @@ import {
   IRootScopeService,
 } from 'angular';
 import $ from 'jquery';
-import { cloneDeep, forOwn, get, set } from 'lodash4';
+import { cloneDeep, forOwn, get, set } from 'lodash3';
 import * as Rx from 'rxjs';
 import { ChromeBreadcrumb, EnvironmentMode, PackageInfo } from 'kibana/public';
 import { History } from 'history';

src/plugins/kibana_legacy/public/angular/promises.js

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import _ from 'lodash4';
+import _ from 'lodash3';
 
 export function PromiseServiceCreator($q, $timeout) {
   function Promise(fn) {

src/plugins/kibana_legacy/public/angular/watch_multi.js

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import _ from 'lodash4';
+import _ from 'lodash3';
 
 export function watchMultiDecorator($provide) {
   $provide.decorator('$rootScope', function ($delegate) {

src/plugins/kibana_legacy/public/angular_bootstrap/index.ts

@@ -1,6 +1,6 @@
 /* eslint-disable */
 
-import { once } from 'lodash4';
+import { once } from 'lodash3';
 import angular from 'angular';
 
 // @ts-ignore

src/plugins/kibana_legacy/public/notify/lib/format_es_msg.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import _ from 'lodash4';
+import _ from 'lodash3';
 
 const getRootCause = (err: Record<string, any> | string) => _.get(err, 'resp.error.root_cause');
 

src/plugins/kibana_legacy/public/notify/lib/format_msg.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import _ from 'lodash4';
+import _ from 'lodash3';
 import { i18n } from '@kbn/i18n';
 import { formatESMsg } from './format_es_msg';
 const has = _.has;

src/plugins/kibana_legacy/public/paginate/paginate.js

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import _ from 'lodash4';
+import _ from 'lodash3';
 import { i18n } from '@kbn/i18n';
 import paginateControlsTemplate from './paginate_controls.html';
 

src/plugins/kibana_legacy/public/utils/migrate_legacy_query.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { has } from 'lodash4';
+import { has } from 'lodash3';
 import { Query } from 'src/plugins/data/public';
 
 /**

src/plugins/kibana_legacy/public/utils/private.js

@@ -93,7 +93,7 @@
  *
  * @param {[type]} prov [description]
  */
-import _ from 'lodash4';
+import _ from 'lodash3';
 
 const nextId = _.partial(_.uniqueId, 'privateProvider#');
 

src/plugins/kibana_legacy/server/index.ts

@@ -23,7 +23,7 @@ import {
   CoreStart,
   PluginConfigDescriptor,
 } from 'kibana/server';
-import { get } from 'lodash4';
+import { get } from 'lodash3';
 
 import { configSchema, ConfigSchema } from '../config';
 

src/plugins/saved_objects/public/finder/saved_object_finder.test.tsx

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-jest.mock('lodash4', () => ({
+jest.mock('lodash3', () => ({
   debounce: (fn: any) => fn,
 }));
 

src/plugins/saved_objects/public/finder/saved_object_finder.tsx

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import _ from 'lodash4';
+import _ from 'lodash3';
 import PropTypes from 'prop-types';
 import React from 'react';
 

src/plugins/saved_objects/public/saved_object/helpers/apply_es_resp.ts

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import _ from 'lodash4';
+import _ from 'lodash3';
 import { EsResponse, SavedObject, SavedObjectConfig, SavedObjectKibanaServices } from '../../types';
 import { SavedObjectNotFound } from '../../../../kibana_utils/public';
 import {

src/plugins/saved_objects/public/saved_object/helpers/build_saved_object.ts

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { once } from 'lodash4';
+import { once } from 'lodash3';
 import { hydrateIndexPattern } from './hydrate_index_pattern';
 import { intializeSavedObject } from './initialize_saved_object';
 import { serializeSavedObject } from './serialize_saved_object';

src/plugins/saved_objects/public/saved_object/helpers/create_source.ts

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import _ from 'lodash4';
+import _ from 'lodash3';
 import { i18n } from '@kbn/i18n';
 import { SavedObjectAttributes } from 'kibana/public';
 import { SavedObject, SavedObjectKibanaServices } from '../../types';

src/plugins/saved_objects/public/saved_object/helpers/initialize_saved_object.ts

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import _ from 'lodash4';
+import _ from 'lodash3';
 import { SavedObjectsClientContract } from 'kibana/public';
 import { SavedObject, SavedObjectConfig } from '../../types';
 

src/plugins/saved_objects/public/saved_object/helpers/save_with_confirmation.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { get } from 'lodash4';
+import { get } from 'lodash3';
 import { i18n } from '@kbn/i18n';
 import {
   SavedObjectAttributes,

src/plugins/saved_objects/public/saved_object/helpers/serialize_saved_object.ts

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import _ from 'lodash4';
+import _ from 'lodash3';
 import { SavedObject, SavedObjectConfig } from '../../types';
 import { extractSearchSourceReferences, expandShorthand } from '../../../../data/public';
 

src/plugins/saved_objects_management/public/lib/case_conversion.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { mapKeys, camelCase } from 'lodash4';
+import { mapKeys, camelCase } from 'lodash3';
 
 export function keysToCamelCaseShallow(object: Record<string, any>) {
   return mapKeys(object, (value, key) => camelCase(key));

src/plugins/saved_objects_management/public/lib/create_field_list.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { forOwn, keyBy, isNumber, isBoolean, isPlainObject, isString } from 'lodash4';
+import { forOwn, indexBy, isNumber, isBoolean, isPlainObject, isString } from 'lodash3';
 import { SimpleSavedObject } from '../../../../core/public';
 import { castEsToKbnFieldTypeName } from '../../../data/public';
 import { ObjectField } from '../management_section/types';
@@ -93,9 +93,9 @@ const addFieldsFromClass = function (
   Class: { mapping: Record<string, string>; searchSource: any },
   fields: ObjectField[]
 ) {
-  const fieldMap = keyBy(fields, 'name');
+  const fieldMap = indexBy(fields, 'name');
 
-  forOwn(Class.mapping, (esType, name) => {
+  _.forOwn(Class.mapping, (esType, name) => {
     if (!name || fieldMap[name]) {
       return;
     }

src/plugins/saved_objects_management/public/lib/get_relationships.ts

@@ -18,7 +18,7 @@
  */
 
 import { HttpStart } from 'src/core/public';
-import { get } from 'lodash4';
+import { get } from 'lodash3';
 import { SavedObjectRelation } from '../types';
 
 export async function getRelationships(

src/plugins/saved_objects_management/public/lib/numeric.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { isNaN } from 'lodash4';
+import { isNaN } from 'lodash3';
 
 export function isNumeric(v: any): boolean {
   return !isNaN(v) && (typeof v === 'number' || (!Array.isArray(v) && !isNaN(parseFloat(v))));

src/plugins/saved_objects_management/public/lib/resolve_saved_objects.ts

@@ -18,7 +18,7 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import { cloneDeep } from 'lodash4';
+import { cloneDeep } from 'lodash3';
 import { OverlayStart, SavedObjectReference } from 'src/core/public';
 import { SavedObject, SavedObjectLoader } from '../../../saved_objects/public';
 import {

src/plugins/saved_objects_management/public/management_section/object_view/components/form.tsx

@@ -26,7 +26,7 @@ import {
   EuiButtonEmpty,
   EuiSpacer,
 } from '@elastic/eui';
-import { cloneDeep, set } from 'lodash4';
+import { cloneDeep, set } from 'lodash3';
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { SimpleSavedObject, SavedObjectsClientContract } from '../../../../../../core/public';

src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx

@@ -18,7 +18,7 @@
  */
 
 import React, { Component, Fragment } from 'react';
-import { take, get as getField } from 'lodash4';
+import { take, get as getField } from 'lodash3';
 import {
   EuiFlyout,
   EuiFlyoutBody,

src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.mocks.ts

@@ -22,8 +22,8 @@ jest.doMock('@elastic/filesaver', () => ({
   saveAs: saveAsMock,
 }));
 
-jest.doMock('lodash4', () => ({
-  ...jest.requireActual('lodash4'),
+jest.doMock('lodash3', () => ({
+  ...jest.requireActual('lodash3'),
   debounce: (func: Function) => {
     function debounced(this: any, ...args: any[]) {
       return func.apply(this, args);

src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

@@ -18,7 +18,7 @@
  */
 
 import React, { Component } from 'react';
-import { debounce } from 'lodash4';
+import { debounce } from 'lodash3';
 // @ts-ignore
 import { saveAs } from '@elastic/filesaver';
 import {

src/plugins/saved_objects_management/public/management_section/saved_objects_table_page.tsx

@@ -18,7 +18,7 @@
  */
 
 import React, { useEffect } from 'react';
-import { get } from 'lodash4';
+import { get } from 'lodash3';
 import { i18n } from '@kbn/i18n';
 import { CoreStart, ChromeBreadcrumb } from 'src/core/public';
 import { DataPublicPluginStart } from '../../../data/public';

src/plugins/saved_objects_management/server/lib/find_all.test.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { times } from 'lodash4';
+import { times } from 'lodash3';
 import { SavedObjectsFindOptions, SavedObject } from 'src/core/server';
 import { savedObjectsClientMock } from '../../../../core/server/mocks';
 import { findAll } from './find_all';