REGEX REPLACE in CMakeLists.txt fails for complex directory paths

[Pathorse]

Bug description

Pinocchio build fails when using complex (symbolic) directory paths, e.g., /test_pinnochio_build/1.0+gitAUTOINC+8ajb23j4b/pinocchio/build, as REGEX REPLACE fails to correctly amend strings before attempting to create symbolic links (or copying).

This issue was found while using pinocchio with the Yocto SDK.

Expected behavior

The build should not fail for any directory paths given.

Reproduction steps

Steps to reproduce the behavior:

1. Create a test folder:

mkdir -p test_pinnochio_build/1.0+gitAUTOINC+8ajb23j4b

2. Clone Pinocchio

git clone git@github.com:stack-of-tasks/pinocchio.git

3. Initialize submodules

cd  test_pinnochio_build/1.0+gitAUTOINC+8ajb23j4b/pinocchio
git submodule update --init

4. Build

mkdir build && cd build
cmake ..

5. See error

Solution

The problem can be solved by replacing REGEX REPLACE with REPLACE, which given the fact that the desired string operation doesnt require the flexibility of regular expressions may make sense to move away from anyways (unless I am missing something here which might be the case as I am pretty new with Pinocchio). The swap must be done in three files:

1. Toplevel CMakeLists.txt
2. Python bindings CMakeLists.txt
3. Unittest CMakelists.txt

System

• OS: Ubuntu 22.04
• Pinocchio version: 2.6.20

[jcarpent]

Thanks @Pathorse for the nice report. @nim65s @jorisv Could you have a look to this issue in more depth?

[nim65s]

I think we should simply switch to a more standard CMake use, and:

1. stop simlinking stuff around
2. list all header / sources in CMakeLists.txt

If agreed, I probably can work on it this week, but probably it would be better to do this on the private branch for v3

[jorisv]

@Pathorse This issue should be fixed by #2070

[Pathorse]

Thanks!

[manumerous]

Thanks a lot!

[jcarpent]

Solve via #2070