Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call non-static member function isNormalized() in static function integrate_impl() #2154

Closed
camfly-zlf opened this issue Feb 12, 2024 · 4 comments · Fixed by #2155
Closed

Call non-static member function isNormalized() in static function integrate_impl() #2154

camfly-zlf opened this issue Feb 12, 2024 · 4 comments · Fixed by #2155
Assignees
@jorisv

Comments

@camfly-zlf
Copy link

pinocchio/include/pinocchio/multibody/liegroup/special-orthogonal.hpp:179
assert (isNormalized(out));

isNormalized() is a non-static member function, I can't build with msvc unless comment out this line
@jorisv jorisv self-assigned this Feb 12, 2024
@jcarpent
Copy link
Contributor

It seems you are compiling in Debug mode (meaning with degraded performances)

@jorisv
Copy link
Contributor

jorisv commented Feb 12, 2024

@camfly-zlf I can reproduce your issue and I will fix it

@camfly-zlf
Copy link
Author

It seems you are compiling in Debug mode (meaning with degraded performances)

yes, I will rebuild it in release mode later

@jorisv jorisv mentioned this issue Feb 12, 2024
Merged
@jorisv jorisv linked a pull request Feb 12, 2024 that will close this issue
Fix ambiguous function call on Windows #2155
Merged
@jorisv
Copy link
Contributor

jorisv commented Feb 13, 2024

Fixed in #2155

@jorisv jorisv closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorisv jorisv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ambiguous function call on Windows jorisv/pinocchio
3 participants
@jorisv @jcarpent @camfly-zlf