Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Support jobs #205

Merged
merged 7 commits into from
Jun 23, 2021
Merged

Support jobs #205

merged 7 commits into from
Jun 23, 2021

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jun 22, 2021 •
edited by soenkeliebau
Loading

Description

Pods with restart policy Never are handled correctly.

Closes #117.

Integration tests are created in stackabletech/agent-integration-tests#37.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

@siegfriedweber siegfriedweber requested a review from a team June 22, 2021 08:39
@siegfriedweber siegfriedweber self-assigned this Jun 22, 2021
@siegfriedweber siegfriedweber changed the title Jobs Support jobs Jun 22, 2021
@siegfriedweber siegfriedweber mentioned this pull request Jun 22, 2021
Merged
@soenkeliebau soenkeliebau mentioned this pull request Jun 23, 2021
Closed
soenkeliebau
soenkeliebau approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ran integration tests and manually created a pod that runs a Kafka command with correct and incorrect parameters to check correct RC handling.

@siegfriedweber siegfriedweber merged commit f1c6f9a into main Jun 23, 2021
@siegfriedweber siegfriedweber deleted the jobs branch June 23, 2021 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soenkeliebau soenkeliebau soenkeliebau approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to run "one shot" commands
2 participants
@siegfriedweber @soenkeliebau