Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Validate repository URL eagerly #262

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Aug 16, 2021

The validation of the repository URL is already performed when a StackableRepoProvider is created and not only when the repository content is requested.

Fixes #197

Description

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

@siegfriedweber siegfriedweber requested a review from a team August 16, 2021 15:21
@siegfriedweber siegfriedweber self-assigned this Aug 16, 2021
The validation of the repository URL is already performed when a
StackableRepoProvider is created and not only when the repository
content is requested.
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one optional comment

@siegfriedweber siegfriedweber merged commit 5e367c0 into main Aug 19, 2021
@siegfriedweber siegfriedweber deleted the validate_repository_url branch August 19, 2021 07:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate repository URLs and warn about and ignore bad repositories
2 participants