Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Set annotation featureRestartCount #289

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Sep 6, 2021

Description

The annotation featureRestartCount is set to true if the restart count in the container status can be set properly. This is the case if systemd version 235 or newer is used. If an older systemd version is used then featureRestartCount is set to false.

Fixes #284
Tested by stackabletech/agent-integration-tests#71

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

The annotation featureRestartCount is set to "true" if the restart count
in the container status can be set properly. This is the case if systemd
version 235 or newer is used. If an older systemd version is used then
featureRestartCount is set to "false".
@siegfriedweber siegfriedweber requested a review from a team September 6, 2021 12:11
@siegfriedweber siegfriedweber self-assigned this Sep 6, 2021
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left just one qestion

src/provider/states/pod/starting.rs Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests fail on CentOS 7 due to missing restart count
2 participants