This repository has been archived by the owner on Dec 21, 2021. It is now read-only.
Added first version of Readme #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfrancke
suggested changes
Jan 21, 2021
|
One general comment: The readme doesn't really explain what this thing does. See https://github.com/virtual-kubelet/systemk for example. |
# Conflicts: # src/agentconfig.rs
…ries to src/bin folder. Added additional binary to generate command line documentation. Moved agentconfig to own module directory.
Also renamed agentconfig module to config as this was repeated verbatim in the struct name AgentConfig.
lfrancke
suggested changes
Jan 25, 2021
lfrancke
approved these changes
Jan 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also contains preliminary code to generate documentation of the command line parameters from our parameter definition in the source code.
It is not the final version, as the doc is currently being generated every time the agent is executed, which we definitely do not want to happen!
The text portions of this PR are ready for review, but the code part I'll rework over the next days.