Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New airflow version 2.6.3, 2.7.2 #334

Merged
merged 16 commits into from Oct 20, 2023
Merged

New airflow version 2.6.3, 2.7.2 #334

merged 16 commits into from Oct 20, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Oct 11, 2023 •
edited by lfrancke

Description

  • added support for 2.6.3, 2.7.2
  • removed support for 2.2.3, 2.2.4, 2.2.5, 2.4.1
  • adapted python imports to be compatible with 2.7.2 (airflow.www.fab_security.manager -> flask_appbuilder.const)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Helm chart can be installed and deployed operator works
    Options
  4. Integration tests passed (for non trivial changes)
    Options
  5. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

@maltesander maltesander requested a review from a team October 11, 2023 12:01
@maltesander maltesander self-assigned this Oct 11, 2023
@maltesander maltesander mentioned this pull request Oct 11, 2023
Closed
16 tasks
@siegfriedweber siegfriedweber mentioned this pull request Oct 12, 2023
Closed
siegfriedweber
siegfriedweber reviewed Oct 17, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@siegfriedweber siegfriedweber requested a review from a team October 17, 2023 13:15
@adwk67 adwk67 requested review from adwk67 and removed request for a team October 18, 2023 07:20
adwk67
adwk67 previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we are getting deprecation messages in e.g. the worker logs that apparently come from config settings that exist in their old location e.g. [core] (old) instead of [database] (new) - however, all our configs seem to be in the right place so I'm not sure where that is coming from. LGTM!

docs/modules/airflow/partials/supported-versions.adoc Show resolved Hide resolved
@maltesander maltesander changed the title New airflow version 2.6.3, 2.7.1 New airflow version 2.6.3, 2.7.2 Oct 18, 2023
@maltesander
Copy link
Member Author

test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/104/

@maltesander
Copy link
Member Author

another try https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/107/

@maltesander
Copy link
Member Author

maltesander commented Oct 20, 2023 •
edited

last one hopefully, 1 worker more memory:
https://ci.stackable.tech/job/airflow-operator-it-custom/109/

adwk67
adwk67 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maltesander maltesander added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit 4a2a5b2 Oct 20, 2023
29 of 30 checks passed
@maltesander maltesander deleted the new-version-2.6.3-2.7.1 branch October 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber left review comments

@adwk67 adwk67 adwk67 approved these changes

Assignees

@maltesander maltesander

Labels
release/2023-11
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maltesander @adwk67 @siegfriedweber @lfrancke