Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed various issues in the CRD structure #353

Merged
merged 3 commits into from Dec 5, 2023
Merged

fix: Fixed various issues in the CRD structure #353

merged 3 commits into from Dec 5, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Dec 5, 2023 •
edited

Description

Part of stackabletech/issues#469

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Helm chart can be installed and deployed operator works
    Options
  4. Integration tests passed (for non trivial changes)
    Options
  5. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

@sbernauer sbernauer self-assigned this Dec 5, 2023
@sbernauer sbernauer mentioned this pull request Dec 5, 2023
Open
fhennig
fhennig previously approved these changes Dec 5, 2023
View reviewed changes
maltesander
maltesander approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit d14a62d Dec 5, 2023
30 checks passed
@sbernauer sbernauer deleted the fix-crd branch December 5, 2023 14:43
@lfrancke lfrancke added type/bug changelog/crd-change Any issue that changes a CRD (breaking and non-breaking changes) should get this label labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

@fhennig fhennig fhennig left review comments

Assignees

@sbernauer sbernauer

Labels
changelog/crd-change Any issue that changes a CRD (breaking and non-breaking changes) should get this label type/bug
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbernauer @fhennig @maltesander @lfrancke