Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump operator-rs to 0.60.1 #366

Merged
merged 31 commits into from Jan 5, 2024
Merged

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jan 3, 2024

Description

Supersedes #364. (I renamed the branch, then Github closed the old PR, oops).

  • BREAKING Removed legacy node selector on roleGroups.
  • Use new label builders.
  • Use new ldap::AuthorizationClassProvider endpoint_url() method

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. CRD documentation for all fields, following the style guide.
    Options
  4. Helm chart can be installed and deployed operator works
    Options
  5. Integration tests passed (for non trivial changes)
    Options
  6. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated. Follows the style guide.
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

sbernauer
sbernauer previously approved these changes Jan 4, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbernauer
Copy link
Member

@sbernauer
Copy link
Member

@NickLarsenNZ NickLarsenNZ changed the title chore: bump operator-rs to 0.60.0 chore: bump operator-rs to 0.60.1 Jan 5, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed 🥳

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jan 5, 2024
@NickLarsenNZ NickLarsenNZ requested a review from a team January 5, 2024 14:24
Merged via the queue into main with commit 4758707 Jan 5, 2024
30 checks passed
@NickLarsenNZ NickLarsenNZ deleted the bump/operator-rs-0.60.0 branch January 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants