Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Support for multiple storage directories #296

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - Support for multiple storage directories #296

wants to merge 12 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 17, 2023 •
edited by maltesander

Description

Fixes #274

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer changed the title Intial implementation Support for multiple storage directories Jan 17, 2023
@maltesander maltesander self-requested a review January 17, 2023 09:00
maltesander
maltesander requested changes Jan 17, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things. LGTM otherwise.

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
rust/crd/src/storage.rs Outdated Show resolved Hide resolved
sbernauer and others added 3 commits January 17, 2023 11:48
@sbernauer @maltesander
Update docs/modules/ROOT/pages/usage.adoc
d3313e6 
Co-authored-by: Malte Sander <contact@maltesander.com>
@sbernauer
review
3f41a41
@sbernauer @maltesander
Update rust/crd/src/lib.rs
37d8d11 
Co-authored-by: Malte Sander <contact@maltesander.com>
@sbernauer
Copy link
Member Author

Thx, let's wait for build and start a final test run

@sbernauer
Copy link
Member Author

Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/51/

maltesander
maltesander approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 17, 2023
@sbernauer
Support for multiple storage directories (#296)
005662e 
# Description

Fixes #274
@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support for multiple storage directories [Merged by Bors] - Support for multiple storage directories Jan 17, 2023
@bors bors bot closed this Jan 17, 2023
@bors bors bot deleted the feature/274-multiple-storage-directories branch January 17, 2023 13:31
@sbernauer sbernauer mentioned this pull request Jan 18, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for multiple storage directories
2 participants
@sbernauer @maltesander