-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Set explicit resources on all containers #359
Conversation
Tests pass on
|
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
I think we decided that the smoke test shouldn't configure any resources explicitly and just test the defaults. I see we didn't do it for Zookeeper but only for Hive.
Pinging @sbernauer for his opinion.
Im fine with that. But there is no test that explicitly tests resources (e.g. the defaults, explicitly set) etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must also change the default resources (cpu,memory,pvc) of every role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly done
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! LGTM when tests pass
bors merge |
Part of stackabletech/issues#394 Co-authored-by: Malte Sander <malte.sander.it@gmail.com> Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de> Co-authored-by: Malte Sander <contact@maltesander.com>
Pull request successfully merged into main. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Part of stackabletech/issues#394