Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let secret-operator handle PKCS#12 conversion #392

Merged
merged 11 commits into from
Sep 26, 2023
Merged

Let secret-operator handle PKCS#12 conversion #392

merged 11 commits into from
Sep 26, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Sep 15, 2023 •
edited
Loading

Description

  • bumped operator-rs
  • use secret operator pkcs12 store with password

fixes #386

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Helm chart can be installed and deployed operator works
    Options
  4. Integration tests passed (for non trivial changes)
    Options
  5. Changes need to be "offline" compatible
    Options
Loading

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options
Loading

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options
Loading

@maltesander maltesander self-assigned this Sep 15, 2023
@maltesander maltesander requested a review from a team September 15, 2023 10:53
@maltesander
Copy link
Member Author

test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/97/

sbernauer
sbernauer requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YEAH!

rust/operator/src/container.rs Outdated Show resolved Hide resolved
rust/operator/src/container.rs Outdated Show resolved Hide resolved
maltesander and others added 2 commits September 26, 2023 14:33
@maltesander @sbernauer
Update rust/operator/src/container.rs
9503c4b 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander
adapt keystore dir / password names
32dc916
sbernauer
sbernauer approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i would prefer TLS_STORES_DIR over TLS_STORE_DIR, sorry!
Other than that LGTM

@maltesander maltesander added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 664efad Sep 26, 2023
30 checks passed
@maltesander maltesander deleted the secret-operator-pkcs-conversion branch September 26, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let secret-operator handle PKCS#12 conversion
2 participants
@maltesander @sbernauer