Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump operator-rs to 0.60 #653

Merged
merged 11 commits into from
Jan 15, 2024
Merged

chore: bump operator-rs to 0.60 #653

merged 11 commits into from
Jan 15, 2024

Conversation

fhennig
Copy link
Member

@fhennig fhennig commented Jan 8, 2024 •
edited by maltesander

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. CRD documentation for all fields, following the style guide.
    Options
  4. Helm chart can be installed and deployed operator works
    Options
  5. Integration tests passed (for non trivial changes)
    Options
  6. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated. Follows the style guide.
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

@fhennig fhennig mentioned this pull request Jan 8, 2024
Closed
@fhennig
Copy link
Member Author

fhennig commented Jan 8, 2024 •
edited

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/55/ 🟢

@fhennig fhennig marked this pull request as ready for review January 8, 2024 15:07
@fhennig fhennig requested a review from a team January 11, 2024 08:51
@maltesander maltesander self-requested a review January 15, 2024 09:43
maltesander
maltesander requested changes Jan 15, 2024
View reviewed changes
rust/crd/src/listener.rs Outdated Show resolved Hide resolved
rust/crd/src/security.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/kafka_controller.rs Outdated Show resolved Hide resolved
fhennig and others added 5 commits January 15, 2024 11:27
@fhennig @maltesander
Update rust/operator-binary/src/kafka_controller.rs
9a9b878 
Co-authored-by: Malte Sander <contact@maltesander.com>
maltesander
maltesander approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhennig fhennig added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit 392a10c Jan 15, 2024
30 checks passed
@fhennig fhennig deleted the chore/bump-operator-rs-0.60 branch January 15, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@fhennig fhennig

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fhennig @maltesander