Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Changed regoRuleReference to optional and default to config-spec #188

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Changed regoRuleReference to optional and default to config-spec #188

wants to merge 4 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jan 24, 2022 •
edited
Loading

Description

  • updated snafu 0.6 -> 0.7
  • updated dependencies
  • adapted config-spec (removed port) and example

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team January 24, 2022 09:37
@maltesander maltesander self-assigned this Jan 24, 2022
nightkr
nightkr approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we might just want to deploy the rego operator as part of opa operator?

@maltesander maltesander marked this pull request as ready for review January 24, 2022 09:40
@maltesander
Copy link
Member Author

Yeah that makes sense.

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 24, 2022
@maltesander
Changed regoRuleReference to optional and default to config-spec (#188)
3fdba8f 
## Description

- updated snafu 0.6 -> 0.7
- updated dependencies
- adapted config-spec (removed port) and example



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 24, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Changed regoRuleReference to optional and default to config-spec [Merged by Bors] - Changed regoRuleReference to optional and default to config-spec Jan 24, 2022
@bors bors bot closed this Jan 24, 2022
@bors bors bot deleted the changed_rego_rule_reference_to_optional branch January 24, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maltesander @nightkr