Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump operator rs 0.61.0 #341

Merged
merged 13 commits into from
Jan 19, 2024
Merged

chore: Bump operator rs 0.61.0 #341

merged 13 commits into from
Jan 19, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jan 9, 2024 •
edited

Description

  • Use new annotation & labels builders
  • Add line breaks between enum variants with spaces/attributes

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. CRD documentation for all fields, following the style guide.
    Options
  4. Helm chart can be installed and deployed operator works
    Options
  5. Integration tests passed (for non trivial changes)
    Options
  6. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated. Follows the style guide.
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

sbernauer
sbernauer previously approved these changes Jan 9, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@NickLarsenNZ
Copy link
Member Author

Tests passed 🚀

@NickLarsenNZ NickLarsenNZ mentioned this pull request Jan 9, 2024
Closed
@Techassi Techassi changed the title Chore/bump operator rs 0.60.1 chore: Bump operator rs 0.60.1 Jan 9, 2024
@Techassi
Copy link
Member

Techassi commented Jan 9, 2024

Sorry, had to rename :)

Techassi
Techassi previously requested changes Jan 9, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/k8s_search.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/csi_server/node.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/csi_server/node.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/csi_server/node.rs Show resolved Hide resolved
@NickLarsenNZ NickLarsenNZ self-assigned this Jan 11, 2024
@NickLarsenNZ NickLarsenNZ dismissed Techassi’s stale review January 11, 2024 18:23

Resolved your comments

@NickLarsenNZ NickLarsenNZ changed the title chore: Bump operator rs 0.60.1 chore: Bump operator rs 0.61.0 Jan 19, 2024
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 1cd7205 Jan 19, 2024
30 checks passed
@NickLarsenNZ NickLarsenNZ deleted the chore/bump-operator-rs-0.60.1 branch January 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

@sbernauer sbernauer Awaiting requested review from sbernauer

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickLarsenNZ @Techassi @sbernauer