Use resolved product version #275

razvan · 2023-08-21T16:04:49Z

Description

Depends on stackabletech/docker-images#436

Part of : #273

🟢 OpenShift tests with custom image:

--- PASS: kuttl (1029.69s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/spark-examples_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (80.30s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (122.61s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_s3-use-tls-true (164.82s)
        --- PASS: kuttl/harness/resources_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (103.91s)
        --- PASS: kuttl/harness/pod_overrides_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (171.40s)
        --- PASS: kuttl/harness/logging_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (450.57s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (136.31s)
        --- PASS: kuttl/harness/spark-pi-public-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (103.35s)
        --- PASS: kuttl/harness/smoke_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_s3-use-tls-true (204.52s)
        --- PASS: kuttl/harness/spark-history-server_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_s3-use-tls-true (278.84s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (139.17s)
PASS

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

Author

Give feedback

Changes are OpenShift compatible

Changes are OpenShift compatible
Options
Successfully updated the issue's project

There was an error updating the issue's project
CRD changes approved

CRD changes approved
Options
Successfully updated the issue's project

There was an error updating the issue's project
Helm chart can be installed and deployed operator works

Helm chart can be installed and deployed operator works
Options
Successfully updated the issue's project

There was an error updating the issue's project
Integration tests passed (for non trivial changes)

Integration tests passed (for non trivial changes)
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Reviewer

Give feedback

Code contains useful comments

Code contains useful comments
Options
Successfully updated the issue's project

There was an error updating the issue's project
(Integration-)Test cases added

(Integration-)Test cases added
Options
Successfully updated the issue's project

There was an error updating the issue's project
Documentation added or updated

Documentation added or updated
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog updated

Changelog updated
Options
Successfully updated the issue's project

There was an error updating the issue's project
Cargo.toml only contains references to git tags (not specific commits or branches)

Cargo.toml only contains references to git tags (not specific commits or branches)
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Acceptance

Give feedback

Feature Tracker has been updated

Feature Tracker has been updated
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper release label has been added

Proper release label has been added
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

rust/operator-binary/src/spark_k8s_controller.rs

maltesander

Just a minor thing. LGTM otherwise.

rust/operator-binary/src/spark_k8s_controller.rs

maltesander

Thanks. LGTM!

lfrancke · 2023-08-28T15:47:13Z

Does this change the CRD?

razvan · 2023-08-28T15:49:04Z

Yes. It makes the CRD more in line with the others.

lfrancke · 2023-08-28T15:51:19Z

So, we need a release note entry?
Anything else for the next release to be aware of here?

lfrancke · 2023-09-22T07:33:38Z

@razvan Do we need any migration steps or anything else for the next version?

razvan · 2023-09-22T07:36:23Z

We need an entry in the release notes that shows both the old and the new way.

razvan added 3 commits August 21, 2023 16:55

First version

0a207ca

Remove redundant image policy.

672b468

Update docs

ddee477

razvan self-assigned this Aug 21, 2023

razvan mentioned this pull request Aug 21, 2023

Refactor to be more in line with other platform operators #273

Closed

razvan added 3 commits August 22, 2023 11:00

Fix image pull policy in tests.

e6081d6

More pull policy fixes for tests.

0f18dc7

Update docs.

0c49b67

razvan mentioned this pull request Aug 22, 2023

Make PySpark the only Spark image. stackabletech/docker-images#436

Merged

razvan requested a review from a team August 22, 2023 12:16

razvan added 4 commits August 22, 2023 14:20

Update supported-versions.adoc

e12efe1

Fix typo

698a030

Readd pull policy

6c96ee4

Cleanups.

4b73f14

razvan mentioned this pull request Aug 23, 2023

Bugfix when using os sep in test case name. stackabletech/beku.py#8

Merged

razvan added 4 commits August 23, 2023 14:45

Add support for custom images in tests.

91b2c0b

typos

efb05c4

Cleanups and more test fixes.

4599120

More typo fixes and OS tests.

42e9965

maltesander reviewed Aug 24, 2023

View reviewed changes

rust/operator-binary/src/spark_k8s_controller.rs Outdated Show resolved Hide resolved

maltesander reviewed Aug 24, 2023

View reviewed changes

rust/operator-binary/src/spark_k8s_controller.rs Outdated Show resolved Hide resolved

Implement review feedback.

2134c56

maltesander approved these changes Aug 24, 2023

View reviewed changes

razvan added this pull request to the merge queue Aug 24, 2023

Merged via the queue into main with commit 268c9cd Aug 24, 2023
30 checks passed

bors bot deleted the feat/product-version branch August 24, 2023 15:35

lfrancke added the release/2023-11 label Aug 28, 2023

lfrancke added the changelog/crd-change Any issue that changes a CRD (breaking and non-breaking changes) should get this label label Aug 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use resolved product version #275

Use resolved product version #275

razvan commented Aug 21, 2023 •

edited by maltesander

Loading

Author

Reviewer

Acceptance

maltesander left a comment

maltesander left a comment

lfrancke commented Aug 28, 2023

razvan commented Aug 28, 2023

lfrancke commented Aug 28, 2023

lfrancke commented Sep 22, 2023

razvan commented Sep 22, 2023

Use resolved product version #275

Use resolved product version #275

Conversation

razvan commented Aug 21, 2023 • edited by maltesander Loading

Description

Definition of Done Checklist

Author

Reviewer

Acceptance

maltesander left a comment

Choose a reason for hiding this comment

maltesander left a comment

Choose a reason for hiding this comment

lfrancke commented Aug 28, 2023

razvan commented Aug 28, 2023

lfrancke commented Aug 28, 2023

lfrancke commented Sep 22, 2023

razvan commented Sep 22, 2023

razvan commented Aug 21, 2023 •

edited by maltesander

Loading