Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the CommonConfiguration structure for roles. #277

Merged
merged 24 commits into from Sep 25, 2023
Merged

Use the CommonConfiguration structure for roles. #277

merged 24 commits into from Sep 25, 2023

Conversation

razvan
Copy link
Member

@razvan razvan commented Sep 4, 2023 •
edited

Description

Part of #273

Refactor the SparkApplication CRD to be more in line with other operators.

The three main roles (job, driver and executor) are now concrete RoleGroup objects under an Role named "default" that is constructed by the operator internally.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Helm chart can be installed and deployed operator works
    Options
  4. Integration tests passed (for non trivial changes)
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. Documentation added or updated
    Options
  3. Changelog updated
    Options
  4. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

@razvan razvan mentioned this pull request Sep 4, 2023
Closed
@razvan
Copy link
Member Author

razvan commented Sep 8, 2023 •
edited

🟢 CI https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/101/

@razvan razvan marked this pull request as ready for review September 8, 2023 10:26
@razvan razvan requested a review from a team September 8, 2023 10:26
@razvan razvan self-assigned this Sep 8, 2023
@razvan razvan mentioned this pull request Sep 11, 2023
Merged
@fhennig fhennig requested review from fhennig and removed request for a team September 13, 2023 11:04
@maltesander maltesander added changelog/breaking Breaking changes changelog/crd-change Any issue that changes a CRD (breaking and non-breaking changes) should get this label labels Sep 13, 2023
fhennig
fhennig reviewed Sep 14, 2023
View reviewed changes
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
fhennig
fhennig requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned before, docs for the roles.rs file would be great, and some of the tests don't look right.

rust/crd/src/roles.rs Show resolved Hide resolved
rust/operator-binary/src/main.rs Show resolved Hide resolved
fhennig
fhennig previously approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan
Copy link
Member Author

razvan commented Sep 21, 2023 •
edited

🟢 CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/103/

@razvan razvan requested a review from fhennig September 21, 2023 07:52
fhennig
fhennig previously approved these changes Sep 25, 2023
View reviewed changes
adwk67
adwk67 requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things.

rust/crd/src/roles.rs Outdated Show resolved Hide resolved
examples/ny-tlc-report-external-dependencies.yaml Show resolved Hide resolved
examples/ny-tlc-report-image.yaml Outdated Show resolved Hide resolved
examples/ny-tlc-report.yaml Outdated Show resolved Hide resolved
@razvan @adwk67
Update rust/crd/src/roles.rs
9cf4441 
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
@razvan razvan requested a review from adwk67 September 25, 2023 10:13
adwk67
adwk67 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 3802141 Sep 25, 2023
30 checks passed
@bors bors bot deleted the refactor/config-overrides branch September 25, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

@fhennig fhennig fhennig left review comments

Assignees

@razvan razvan

Labels
changelog/breaking Breaking changes changelog/crd-change Any issue that changes a CRD (breaking and non-breaking changes) should get this label
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@razvan @adwk67 @fhennig @maltesander @sbernauer