Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing deletecollection RBAC permission #313

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 28, 2023

Description

Fixes #316
Other user has reported as well:

When I’m running my teragen spark job I see an error at the end. Is the default RBAC not being applied is something missing from it?

2023-11-28T13:05:23,601 ERROR [main] org.apache.spark.util.Utils - Uncaught exception in thread main io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: DELETE at: https://kubernetes.default.svc/api/v1/namespaces/default/configmaps?labelSelector=spark-app-selector%3Dspark-6d6176af4a3244b3932a9ef1ad5c53fe%2Cspark-role%3Dexecutor. Message: Forbidden!Configured service account doesn't have access. Service account may have been revoked. configmaps is forbidden: User "system:serviceaccount:default:spark-teragen" cannot deletecollection resource "configmaps" in API group "" in the namespace "default".

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@maltesander
Copy link
Member

Should this be cherry picked to 23.11?

@lfrancke
Copy link
Member

If we can, that'd be great. But if it is too much of a hassle leave it.

@sbernauer
Copy link
Member Author

+1. We already had a discussion on Slack as well: https://stackable-workspace.slack.com/archives/C037Q9DPF4P/p1701180253227739

@sbernauer sbernauer added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 2566ef9 Dec 4, 2023
30 checks passed
@sbernauer sbernauer deleted the fix/spark-rbac-deletecollection branch December 4, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Service account doesn't have correct permissions to delete resources
4 participants