fix: Rename Service port name from superset to http (#394)

* Rename Service port name from `superset` to `http` for consistency reasons * changelog * Update CHANGELOG.md
stackabletech · Aug 11, 2023 · cef750e · cef750e
1 parent 4a508f4
commit cef750e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,8 +11,13 @@
 - `vector` `0.26.0` -> `0.31.0` ([#391]).
 - `operator-rs` `0.44.0` -> `0.45.1` ([#390]).
 
+### Fixed
+
+- BREAKING: Rename Service port name from `superset` to `http` for consistency reasons. This change should normally not be breaking, as we only change the name, not the port. However, there might be some e.g. Ingresses that rely on the port name and need to be updated ([#394]).
+
 [#390]: https://github.com/stackabletech/superset-operator/pull/390
 [#391]: https://github.com/stackabletech/superset-operator/pull/391
+[#394]: https://github.com/stackabletech/superset-operator/pull/394
 
 ## [23.7.0] - 2023-07-14
 

diff --git a/rust/crd/src/lib.rs b/rust/crd/src/lib.rs
@@ -129,8 +129,6 @@ impl FlaskAppConfigOptions for SupersetConfigOptions {
     }
 }
 
-pub const HTTP_PORT: &str = "http";
-
 #[derive(Clone, CustomResource, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
 #[kube(
     group = "superset.stackable.tech",

diff --git a/rust/operator-binary/src/superset_controller.rs b/rust/operator-binary/src/superset_controller.rs
@@ -413,7 +413,7 @@ fn build_node_role_service(
                     .k8s_service_type(),
             ),
             ports: Some(vec![ServicePort {
-                name: Some("superset".to_string()),
+                name: Some("http".to_string()),
                 port: APP_PORT.into(),
                 protocol: Some("TCP".to_string()),
                 ..ServicePort::default()
@@ -525,7 +525,7 @@ fn build_node_rolegroup_service(
             cluster_ip: Some("None".to_string()),
             ports: Some(vec![
                 ServicePort {
-                    name: Some("superset".to_string()),
+                    name: Some("http".to_string()),
                     port: APP_PORT.into(),
                     protocol: Some("TCP".to_string()),
                     ..ServicePort::default()