-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Mutual TLS and S3 TLS verification #244
Conversation
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't gone through all of it yet, but it's a starting point
Co-authored-by: Teo Klestrup Röijezon <teo@nullable.se>
split up trust/keystores in internal, client, server
def test_query_failure(conn, query, error): | ||
cursor = conn.cursor() | ||
try: | ||
cursor.execute(query) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to raise an exception here if nothing fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done b507aee
Co-authored-by: Teo Klestrup Röijezon <teo@nullable.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
147 comments later… phew |
bors merge |
# Description - Now internal and client TLS can be configured instead of defaulting to "tls" secret class - S3 now supports proper TLS authentication closes #217 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Pull request successfully merged into main. Build succeeded: |
Description
closes #217
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information