Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add support for Google sheets connector #337

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Add support for Google sheets connector #337

wants to merge 6 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 7, 2022 •
edited by adwk67
Loading

Closes #339

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer changed the title Intial support for Google Sheets connector Add support for Google sheets connector Nov 8, 2022
@sbernauer sbernauer marked this pull request as ready for review November 8, 2022 11:22
adwk67
adwk67 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % missing-trino-link

docs/modules/ROOT/pages/concepts.adoc Show resolved Hide resolved
rust/operator-binary/src/catalog/config.rs Show resolved Hide resolved
@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 14, 2022
@sbernauer
Add support for Google sheets connector (#337)
e2d859b 
Closes #339
@bors
Copy link
Contributor

bors bot commented Nov 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add support for Google sheets connector [Merged by Bors] - Add support for Google sheets connector Nov 14, 2022
@bors bors bot closed this Nov 14, 2022
@bors bors bot deleted the google-sheets-connector branch November 14, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Google Sheets connector
2 participants
@sbernauer @adwk67