Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Removed tools image for init container #357

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Removed tools image for init container #357

wants to merge 4 commits into from

Conversation

sbernauer
Copy link
Member

Description

todo: adopt stackable versions in tests

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer mentioned this pull request Dec 13, 2022
Merged
@maltesander maltesander mentioned this pull request Dec 13, 2022
Closed
6 tasks
@maltesander
Copy link
Member

test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/36/

@maltesander maltesander marked this pull request as ready for review December 13, 2022 16:53
@sbernauer
Copy link
Member Author

Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/37/console

maltesander
maltesander approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maltesander
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Dec 14, 2022
@sbernauer @maltesander
Removed tools image for init container (#357)
e824b4e 
# Description

todo: adopt stackable versions in tests



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Removed tools image for init container [Merged by Bors] - Removed tools image for init container Dec 14, 2022
@bors bors bot closed this Dec 14, 2022
@bors bors bot deleted the tools-image branch December 14, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbernauer @maltesander