Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version 428 #491

Merged
merged 12 commits into from Oct 19, 2023
Merged

New version 428 #491

merged 12 commits into from Oct 19, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Oct 17, 2023 •
edited

Description

  • added support for 428 with new opa authorizer
  • removed support for versions 377, 387, 395, 396, 403
  • now opa regos are differentiated in tests for 414 and 428 (old vs new authorizer)
  • bumped operator-rs to 0.55.0
  • bumped vector to 0.33.0

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Helm chart can be installed and deployed operator works
    Options
  4. Integration tests passed (for non trivial changes)
    Options
  5. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

@maltesander maltesander requested a review from a team October 17, 2023 14:13
@maltesander maltesander self-assigned this Oct 17, 2023
@maltesander maltesander mentioned this pull request Oct 17, 2023
Closed
16 tasks
@maltesander maltesander marked this pull request as ready for review October 17, 2023 14:36
@siegfriedweber siegfriedweber mentioned this pull request Oct 18, 2023
Closed
@maltesander maltesander mentioned this pull request Oct 18, 2023
Open
@maltesander
Copy link
Member Author

test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/106/

@adwk67 adwk67 requested review from adwk67 and removed request for a team October 18, 2023 15:55
adwk67
adwk67 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sbernauer
sbernauer approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@maltesander maltesander added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit 690cac2 Oct 19, 2023
30 checks passed
@maltesander maltesander deleted the new-version-428 branch October 19, 2023 09:54
@maltesander maltesander mentioned this pull request Oct 24, 2023
Closed
@maltesander maltesander mentioned this pull request Nov 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels
release/2023-11
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maltesander @adwk67 @sbernauer @lfrancke