Skip to content

Navigation Menu

Explore
By size
By industry
By use case
Resources
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

stackabletech / trino-operator Public

Notifications You must be signed in to change notification settings
Fork 7
Star 46

Code
Issues 40
Pull requests 1
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Added overrides docs #518

Merged

fhennig merged 2 commits into main from feat/475-document-overrides

Jan 2, 2024

Merged

feat(docs): Added overrides docs #518

fhennig merged 2 commits into main from feat/475-document-overrides

Jan 2, 2024

Conversation 2 Commits 2 Checks 29 Files changed

Conversation

Copy link

Member

fhennig commented Jan 2, 2024

Description

fixes #475

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

The content you are editing has changed. Please copy your edits and refresh the page.

Title of tasklist

Author

Edit tasklist title

Beta Give feedback

Tasklist Author, more options

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Changes are OpenShift compatible

Changes are OpenShift compatible
Options
Successfully updated the issue's project

There was an error updating the issue's project
CRD changes approved

CRD changes approved
Options
Successfully updated the issue's project

There was an error updating the issue's project
CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).

CRD documentation for all fields, following the style guide.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Helm chart can be installed and deployed operator works

Helm chart can be installed and deployed operator works
Options
Successfully updated the issue's project

There was an error updating the issue's project
Integration tests passed (for non trivial changes)

Integration tests passed (for non trivial changes)
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changes need to be "offline" compatible

Changes need to be "offline" compatible
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Type to add an item or paste in an issue URL

Loading

The content you are editing has changed. Please copy your edits and refresh the page.

Title of tasklist

Reviewer

Edit tasklist title

Beta Give feedback

Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Code contains useful comments

Code contains useful comments
Options
Successfully updated the issue's project

There was an error updating the issue's project
(Integration-)Test cases added

(Integration-)Test cases added
Options
Successfully updated the issue's project

There was an error updating the issue's project
Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).

Documentation added or updated. Follows the style guide.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog updated

Changelog updated
Options
Successfully updated the issue's project

There was an error updating the issue's project
Cargo.toml only contains references to git tags (not specific commits or branches)

Cargo.toml only contains references to git tags (not specific commits or branches)
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Type to add an item or paste in an issue URL

Loading

The content you are editing has changed. Please copy your edits and refresh the page.

Title of tasklist

Acceptance

Edit tasklist title

Beta Give feedback

Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Feature Tracker has been updated

Feature Tracker has been updated
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper release label has been added

Proper release label has been added
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Type to add an item or paste in an issue URL

Loading

Sorry, something went wrong.

All reactions


          Added overrides docs

aea5cf0

sbernauer reviewed

View reviewed changes

Copy link

Member

sbernauer left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Sorry, something went wrong.

All reactions

docs/modules/trino/pages/usage-guide/overrides.adoc Outdated Show resolved Hide resolved


          Adress review comment

15176a9

sbernauer approved these changes

View reviewed changes

fhennig enabled auto-merge

January 2, 2024 15:15

fhennig added this pull request to the merge queue

Merged via the queue into main with commit ebab8e6

30 checks passed

fhennig deleted the feat/475-document-overrides branch

January 2, 2024 15:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbernauer sbernauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: Document overrides.

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.