Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Clean up orphaned resources #569

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Clean up orphaned resources #569

wants to merge 9 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 13, 2022

Description

Fixes #458

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr added the changelog/breaking Breaking changes label Oct 13, 2022
@nightkr nightkr requested a review from a team October 13, 2022 11:07
@nightkr nightkr marked this pull request as ready for review October 13, 2022 11:35
@maltesander maltesander self-requested a review October 13, 2022 12:20
maltesander
maltesander reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question. Started test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/zookeeper-operator-it-custom/19/

rust/operator-binary/src/zk_controller.rs Show resolved Hide resolved
maltesander
maltesander approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/zookeeper-operator-it-custom/19/ works

@nightkr
Copy link
Member Author

nightkr commented Oct 13, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 13, 2022
@nightkr
Clean up orphaned resources (#569)
cf67693 
# Description

Fixes #458
@bors
Copy link
Contributor

bors bot commented Oct 13, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Clean up orphaned resources [Merged by Bors] - Clean up orphaned resources Oct 13, 2022
@bors bors bot closed this Oct 13, 2022
@bors bors bot deleted the feature/orphan-cleanup branch October 13, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
changelog/breaking Breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle stale information/clean up stale resources
2 participants
@nightkr @maltesander