Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new version 3.8.3 #732

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Add new version 3.8.3 #732

merged 10 commits into from
Oct 18, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Oct 9, 2023 •
edited
Loading

Description

  • added removed and deprecated versions docs
  • bumped zk version to 3.8.3

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Helm chart can be installed and deployed operator works
    Options
  4. Integration tests passed (for non trivial changes)
    Options
  5. Changes need to be "offline" compatible
    Options
Loading

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options
Loading

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options
Loading

@maltesander maltesander requested a review from a team October 9, 2023 08:22
@maltesander maltesander self-assigned this Oct 9, 2023
@maltesander maltesander mentioned this pull request Oct 9, 2023
Closed
16 tasks
@maltesander maltesander marked this pull request as ready for review October 9, 2023 11:21
@siegfriedweber siegfriedweber mentioned this pull request Oct 12, 2023
Closed
@maltesander maltesander changed the title Add new version 3.8.2 Add new version 3.8.3 Oct 16, 2023
razvan
razvan reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos

docs/modules/zookeeper/examples/getting_started/code/getting_started.sh Outdated Show resolved Hide resolved
docs/modules/zookeeper/examples/getting_started/code/getting_started.sh.j2 Outdated Show resolved Hide resolved
@maltesander @razvan
Apply suggestions from code review
1c93e32 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@maltesander
Copy link
Member Author

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/zookeeper-operator-it-custom/65/

@maltesander maltesander added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit caeb453 Oct 18, 2023
29 of 30 checks passed
@maltesander maltesander deleted the add-new-version-3.8.2 branch October 18, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@maltesander maltesander

Labels
release/2023-11
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maltesander @razvan @lfrancke