Some README improvements #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzylowski
force-pushed
the
readme_updates
branch
from
22ff1af
to
0bf0ec2
Compare
PiotrProkop
reviewed
Jan 18, 2017
| @@ -46,8 +46,10 @@ Example: | |||
| ### Daemonset | |||
| Checks if a specified daemonset is already running on the same host, this dependency requires a `POD_NAME` | |||
| env which can be easily passed through the [downward api](http://kubernetes.io/docs/user-guide/downward-api/). | |||
| The `POD_NAME` variable is used to determine right host to check dependencies. | |||
There was a problem hiding this comment.
I would change it to :
The POD_NAME variable is mandatory and is used to resolve dependencies.
| Example: | ||
|
|
||
| `POD_NAME=nova` |
There was a problem hiding this comment.
I would delete this POD_NAME has to passed via downward api.
| @@ -73,7 +75,12 @@ Example: | |||
|
|
|||
| `DEPENDENCY_SOCKET=/var/run/openvswitch/ovs.socket` | |||
|
|
|||
| ## Image | |||
|
|
|||
| Image is build after every push to kubernetes-entrypoint repository. | |||
There was a problem hiding this comment.
I would change it to :
Build process for image is trigged after each commit.
mzylowski
force-pushed
the
readme_updates
branch
from
0bf0ec2
to
655b28a
Compare
PiotrProkop
reviewed
Jan 18, 2017
| @@ -46,6 +46,7 @@ Example: | |||
| ### Daemonset | |||
| Checks if a specified daemonset is already running on the same host, this dependency requires a `POD_NAME` | |||
| env which can be easily passed through the [downward api](http://kubernetes.io/docs/user-guide/downward-api/). | |||
| The `POD_NAME` variable is mandatory and is used to resolve dependencies. | |||
| Example: | |||
|
|
|||
There was a problem hiding this comment.
Add example of using downward api.
mzylowski
force-pushed
the
readme_updates
branch
from
655b28a
to
eb4ca84
Compare
|
Added link to example how to use downward api |
Information about kubernetes-entrypoint docker image Improved daemonset usage
mzylowski
force-pushed
the
readme_updates
branch
from
eb4ca84
to
129413f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Related with #15
cc @DTadrzak @PiotrProkop