Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent documentation vs implementation of transitive argument #56

Closed
aaliddell opened this issue Mar 9, 2019 · 1 comment
Closed

Inconsistent documentation vs implementation of transitive argument #56

aaliddell opened this issue Mar 9, 2019 · 1 comment

Comments

@aaliddell
Copy link
Contributor

aaliddell commented Mar 9, 2019 •
edited
Loading

For a number of languages, the readme states that transitive has a default of false: https://github.com/stackb/rules_proto/blame/master/python/README.md#L329

Whilst in the bzl file the argument is ignored and is harddoded as true:

rules_proto/python/python_grpc_library.bzl

Line 16 in f5d6eea

transitive = True,

To correct for this, two things need doing:

  • The documentation should be updated to state the default is True for affected languages
  • The rules of affected languages should not use hardcoded true; the value should be pulled from kwargs with a default of true: transitive = kwargs.get("transitive", True)

If this sounds correct, I can send this as a PR?
@aaliddell aaliddell mentioned this issue May 8, 2019
Closed
aaliddell added a commit to aaliddell/rules_proto that referenced this issue Jun 13, 2019
@aaliddell
Mark transitive attr as default true
d749550 
Default behaviour of all languages has presently been True anyway,
so this is just updating the docs to match the implementation.
Closes stackb#56
@aaliddell aaliddell mentioned this issue Jun 24, 2019
Closed
@aaliddell aaliddell mentioned this issue Jul 19, 2019
Closed
29 tasks
@pcj
Copy link
Member

pcj commented Nov 16, 2021

Closing stale PRs and issue, please reopen new one if desired.

@pcj pcj closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcj @aaliddell