fix: don't depend on JAVA_HOME #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my Mac, I don't have a Java installation, so I can't run Coursier in a repo rule.
Error looks like the following:
```
ERROR: An error occurred during the fetch of repository 'maven':
Traceback (most recent call last):
File "/private/var/tmp/_bazel_alexeagle/ae0af0834eef79816f461fa88cebe300/external/rules_jvm_external/coursier.bzl", line 795, column 13, in _coursier_fe
common --enable_platform_specific_config
tch_impl
fail("Unable to run coursier: " + hasher_exec_result.stderr)
Error in fail: Unable to run coursier: The operation couldn’t be completed. Unable to locate a Java Runtime.
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Mac, I don't have a Java installation, so I can't run Coursier in a repo rule. This change fixes it.
Error looks like the following: