-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get the scrub-themes.js script working #42
Comments
I'm currently working on this so I can then move #26 forward. @JugglerX What do you want the cutoff date for determining the "stale" status? A hardcoded date of January 1st, 2018 is being used. It should likely be based on a calculation from the current date. Is something like current date minus one year acceptable (so a repo without a commit in the past year would be considered stale)? Or should the period be shorter than a year? |
Script now adds the following to a theme's front matter: - Add a stale flag if not commits in past year - Add github branch (if missing) Added scrub-themes to scripts in package.json. Fixes stackbit#42
@rgroves thanks for the PR with the scrub script. I did some work today which generates the github_branch and last_commit data in the I was able to run I tested the scrub script to generate stale data and it does, great! But I think this data should live in the Really appreciate your work on this, thanks! :) |
Sorry, I originally misunderstood where the stale flag should reside. I can work on moving this into |
Ok sure. I agree it should exist in Broadly speaking. We want to avoid modifying the markdown files as much as possible. The scrub script should be used to make major updates to the markdown files when otherwise unavoidable. |
That makes sense. Will have a PR for this later today. |
The scrub-themes script needs to be rewritten to implement the functionality mentioned in this comment in #12 and this comment in #26.
The
scrub-themes.js
script needs to update the theme markdown files incontent/theme/
by:This process should be driven by the theme data stored in
data/themes.json
(which is generated by thegenerate-github.js
script). Each theme object stored within the themes.json has the appropriatelast_commit
andbranch
that should be used in implementing the above requirements.The text was updated successfully, but these errors were encountered: