Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: incorrect cache hit #11

Closed
shykes opened this issue Apr 21, 2020 · 1 comment
Closed

s3: incorrect cache hit #11

shykes opened this issue Apr 21, 2020 · 1 comment

Comments

@shykes
Copy link
Contributor

shykes commented Apr 21, 2020

In some situations, s3.Put will hit the task cache, causing the put task to NOT be executed. This is a silent error: the change will appear to be applied successfully, but in reality no upload has taken place.

To reproduce:

  1. s3.Put with inputs A. This task will execute correctly.
  2. s3.Put with inputs B different from B. For example, file contents may be different. This task wil also execute corectly.
  3. s3.Put with inputs A. All inputs must be identical to the first run. THIS TASK WILL BE INCORRECTLY CACHED.

This error is not specific to S3. Any package with side-effects may be affected.

samalba added a commit that referenced this issue Apr 21, 2020
Signed-off-by: Sam Alba <sam.alba@gmail.com>
@samalba
Copy link
Contributor

samalba commented Apr 21, 2020

Fixed

@samalba samalba closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants