Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add name/key property to AttachStep instead of index #134

Open
AnsonT opened this issue Nov 21, 2023 · 1 comment
Open

Suggestion: Add name/key property to AttachStep instead of index #134

AnsonT opened this issue Nov 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@AnsonT
Copy link

AnsonT commented Nov 21, 2023

I'd like to suggest that instead using index to map the attach step to the steps array, it'll be more flexible to use a key/name for the attachStep, and the steps array just referencnes the key. This way, it's easy to rearrange the order of the steps just by rearranging the steps array, instead of renumbering the AttachSteps all around the application.

@JoseLion
Copy link
Member

Thank you very much for the suggestion. I like the idea; I have been thinking about this for some time now. The main challenge is keeping type safety around the keys and the steps, but it's not a blocker. As you mentioned, using keys instead of indexes has more than one benefit. We'll put this under our scope next.

@JoseLion JoseLion added the enhancement New feature or request label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants