Add tests for the lexer #18
Conversation
| @@ -0,0 +1,145 @@ | |||
| require_relative "../test_helper" | |||
|
|
|||
| describe SimpleTemplates::Lexer do | |||
There was a problem hiding this comment.
Did you make sure that these fail in the right place, by writing the test, and then changing the code to make the test red?
There was a problem hiding this comment.
We tested the new additions and check the edges cases for the VALID_PLACEHOLDER in the lexer
|
This is looking pretty good. Can you rebase this on top of my other branch (not sure if you've done that already). |
juanpaucar
force-pushed
the
add_tests_for_lexer
branch
from
3c26dc8
to
8c48058
Compare
|
@jsl Done. Rebased on top of your branch |
|
LGTM, can you rebase on top of master (#17 is merged) as we are improving tests here can you also run it with Mutant => http://solnic.eu/2013/01/23/mutation-testing-with-mutant.html (it could be separate PR if Mutant finds a lot of problems) |
|
also please update #4 |
juanpaucar
force-pushed
the
add_tests_for_lexer
branch
from
8c48058
to
2c02fea
Compare
|
@mpapis It's a great idea to use mutation tests for what I've seen. But currently we are using minitest for the test suite, and |
|
@juanpaucar I'd prefer to avoid switching to rspec, since it's a significantly heavier dependency. At any rate, that could be in another PR. I'll open an issue to investigate mutation testing or other property-based testing, since that could be useful for the library. |
@jsl @mcelicalderon Could you take a look, please? We used several of Mario's tests for the lexer