Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import #46

Closed
wants to merge 4 commits into from
Closed

Import #46

wants to merge 4 commits into from

Conversation

yoshuawuyts
Copy link
Contributor

Testing imports relies on global: true functionality to exist; as else the import will just be prefixed - which is no good for anyone.

  • fix plugin test
  • write import functionality
  • write tests for imports
  • write global: true functionality
  • test global: true functionality

@yoshuawuyts
Copy link
Contributor Author

I feel the internals might be getting slightly messy - style-deps could probably use a couple of additions - but that's ok for now, I have a feeling the external contract is solid, we can always refactor afterwards. Goal for now is to release v4 asap

@yoshuawuyts
Copy link
Contributor Author

Cool! So this PR should now resolve css packages from npm correctly (extract to separate module afterwards), and add the { global: true } flag for imports. Effectively implements #35 and what was #36

@yoshuawuyts
Copy link
Contributor Author

It goes without saying that this should massively be refactored afterwards - there's some questionable stuff going on, but at least we're hitting the functionality we want (':

@yoshuawuyts
Copy link
Contributor Author

Tests are passing so I'm just going to merge away. Will ask for a final review round for a v4 release, but eh - if it works I merge - till then

@yoshuawuyts yoshuawuyts deleted the import branch February 10, 2016 04:26
ahdinosaur pushed a commit that referenced this pull request Feb 16, 2016
Signed-off-by: Yoshua Wuyts <i@yoshuawuyts.com>

Closes #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant