Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing VERSION file on master branch #128

Closed
StevenYCChou opened this issue May 17, 2019 · 0 comments
Closed

Confusing VERSION file on master branch #128

StevenYCChou opened this issue May 17, 2019 · 0 comments
Assignees
Labels
cleanup Internal cleanup

Comments

@StevenYCChou
Copy link
Contributor

VERSION file on master branch is confusing. For example,
fc1c9e2 is included in release 0.4.2, but the VERSION file still shows as 0.4.0.

#81 pointed out VERSION file is used to build the binary. Here is an example when you show the version of the binary:

$ ./stackdriver-prometheus-sidecar --version
prometheus, version 0.4.0 (branch: master, revision: b9b9b5facf6dc90e233ce93927960d5aee4bf360)
  build user:       [REDACTED]
  build date:       20190517-14:47:05
  go version:       go1.12

I purpose that we use latest in VERSION on master, so when anyone build the binary from master, this user knows that it's not on a specific named version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal cleanup
Projects
None yet
Development

No branches or pull requests

2 participants