Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty SSR data on deployments without refresh #449

Open
huumn opened this issue Aug 28, 2023 · 5 comments
Open

Empty SSR data on deployments without refresh #449

huumn opened this issue Aug 28, 2023 · 5 comments

Comments

@huumn
Copy link
Member

huumn commented Aug 28, 2023

We are still getting stale caches when we deploy new code. I have to close and reopen the PWA and I have to refresh in browser otherwise I'm served old pages.

@huumn huumn added the bug label Aug 28, 2023
@huumn
Copy link
Member Author

huumn commented Oct 1, 2023

We really need to figure this out. It's making me shy with deployments because the whole client side goes stale until it's refreshed.

@ekzyis
Copy link
Member

ekzyis commented Oct 2, 2023

afaik, we used to nuke the whole cache on deployments but can't find that code anymore

@huumn
Copy link
Member Author

huumn commented Oct 4, 2023

I think what's happening is the build manifest and pages are getting cached on both the client and in the CDN ... so if there's any attempt to revalidate after deploying, it comes back as valid from the CDN.

So when we ship a new release there's nothing to let the client know they're fetching old files/data because the manifest points to old files and old files point to the manifest.

nope, so wrong

@huumn
Copy link
Member Author

huumn commented Oct 5, 2023

This might be the issue vercel/next.js#51823

not it

@huumn
Copy link
Member Author

huumn commented Oct 14, 2023

This appears to be a bug in nextjs. If it for some reason isn't a bug or they don't want to fix it, we will need to figure out a hack around it ... either profiling responses in the service worker or removing the header (which might have unexpected consequences).

vercel/next.js#56852

@huumn huumn changed the title Stale caches on deployment Empty SSR data on deployments Oct 15, 2023
@huumn huumn changed the title Empty SSR data on deployments Empty SSR data on deployments without refresh Oct 15, 2023
@huumn huumn added the blocked label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants