Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Read more" button sometimes does not show up #687

Closed
ekzyis opened this issue Dec 14, 2023 · 4 comments
Closed

"Read more" button sometimes does not show up #687

ekzyis opened this issue Dec 14, 2023 · 4 comments
Labels

Comments

@ekzyis
Copy link
Member

ekzyis commented Dec 14, 2023

@Onions keeps complaining to me in SimpleX DMs that there is a bug with "Read more" where it doesn't show up. Then I told him: "Why don't you just create a ticket and help us helping you?"

Then I realized, he already told me he has no Github account, lol. So I said sorry, I am going to create one now and here I am, creating this ticket for him.

For example, he goes to preview, and then he can't see everything because it's hidden and there isn't even that button (happens only sometimes, I think).

I just had this bug on my own profile even since my profile isn't even that long but it still seemed to want to display the button but there was no button.

Probably a race condition somewhere.

Github should really allow anon tickets, lol. Can't expect everyone to have an account on here.

@ekzyis ekzyis added the bug label Dec 14, 2023
@ekzyis
Copy link
Member Author

ekzyis commented Dec 15, 2023

caught the bug:

2023-12-15.19-32-32.mp4

huumn added a commit that referenced this issue Dec 16, 2023
@huumn
Copy link
Member

huumn commented Dec 16, 2023

This might be fixed now

@ekzyis
Copy link
Member Author

ekzyis commented Dec 16, 2023

Ok will let you know if it happens again within a week

Since I think it did happen frequently enough that if it doesn't happen in a week, it's probably fixed and we can close it :)

@huumn huumn closed this as completed in fc3f46a Dec 17, 2023
@huumn
Copy link
Member

huumn commented Dec 17, 2023

I think this is ultimately related to images causing the container height to change after they load. My more recent fix observes the container size for changes which I think solves this once and for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants