Zaps not registered on first click if modal was closed before #771
Labels
Comments
|
Can confirm this has been a bug since we added |
Merged
jp30566347
added a commit
to jp30566347/stacker.news
that referenced
this issue
Apr 11, 2024
- Extract handlers - Remove unnecessary async keyword from callback - Assign a new key to force remounting of LongPressable component when modal is closed from long press - Remove hover state when closing modal, otherwise it stays colored
4 tasks
|
This is a hard one. Couldn't find a root cause, but have a workaround. |
huumn
pushed a commit
that referenced
this issue
Apr 12, 2024
* Fix first zap when modal closed (#771) - Extract handlers - Remove unnecessary async keyword from callback - Assign a new key to force remounting of LongPressable component when modal is closed from long press - Remove hover state when closing modal, otherwise it stays colored * Replace LongPressable with custom component * Remove yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The first short press on a zap icon is not registered if a modal was closed before.
Steps to Reproduce
Expected behavior
Zaps are always registered
Video
2024-01-30.02-43-51.mp4
Additional context
I thought it might be related to the document losing focus on modal open and the modal not giving back focus to the document, but
document.activeElementreturned the same before and after a modal was closed.Also, if you add
onClickto a parent element (see video), it does get registered. So I think it's something wrong withLongPressableand not related to missing focus. Using raw HTML works as expected.I think this was always the case but it annoyed me enough while working on #749 to create a ticket now for this and I found easy steps to reproduce now.
The text was updated successfully, but these errors were encountered: