New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypeError: Failed to construct 'URL': Invalid URL #1083
Conversation
WalkthroughWalkthroughThe recent update to the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
try { | ||
url = !href.startsWith('/') && new URL(href) | ||
} catch { | ||
// ignore invalid URLs | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding logging for the caught exceptions when URL parsing fails.
This will help in monitoring and debugging issues related to URL parsing without affecting the user experience. For example:
console.warn(`Failed to parse URL: ${href}`, error);
Description
This site currently gives me a 500 error: https://stacker.news/items/508794
This is the error in the console:
TypeError: Failed to construct 'URL': Invalid URL
Checklist
Summary by CodeRabbit