Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError: Failed to construct 'URL': Invalid URL #1083

Merged
merged 1 commit into from Apr 17, 2024
Merged

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Apr 17, 2024

Description

This site currently gives me a 500 error: https://stacker.news/items/508794

This is the error in the console: TypeError: Failed to construct 'URL': Invalid URL

Checklist

  • Are your changes backwards compatible?
  • Did you QA this? Could we deploy this straight to production?
  • For frontend changes: Tested on mobile?
  • Did you introduce any new environment variables? If so, call them out explicitly in the PR description.

Summary by CodeRabbit

  • Bug Fixes
    • Improved URL error handling in the Text component to gracefully ignore invalid URLs and enhanced URL origin checks.

@ekzyis ekzyis added the bug label Apr 17, 2024
Copy link
Contributor

coderabbitai bot commented Apr 17, 2024

Walkthrough

Walkthrough

The recent update to the Text component enhances error handling by introducing a try-catch block that effectively manages URL parsing errors. This ensures that invalid URLs are gracefully ignored. Additionally, the update refines the URL origin check by incorporating optional chaining, which improves the robustness and readability of the condition.

Changes

File Change Summary
components/text.js Introduced a try-catch block for URL parsing errors and updated the URL origin check to use optional chaining.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7d587c7 and 0ec97b2.
Files selected for processing (1)
  • components/text.js (2 hunks)
Additional comments not posted (1)
components/text.js (1)

199-199: The use of optional chaining here is appropriate and enhances the robustness of the code.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment on lines +182 to +186
try {
url = !href.startsWith('/') && new URL(href)
} catch {
// ignore invalid URLs
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding logging for the caught exceptions when URL parsing fails.

This will help in monitoring and debugging issues related to URL parsing without affecting the user experience. For example:

console.warn(`Failed to parse URL: ${href}`, error);

@huumn huumn merged commit 40463d5 into master Apr 17, 2024
5 checks passed
@ekzyis ekzyis deleted the fix-invalid-url branch April 20, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants