bug | #995 | add TypePolicy to Fact

[itsrealfake]

closes #995

enables apollo cache to work for 'stacked' 'spent' in /statistics page.

Description

Screenshots

Additional Context

Checklist

Are your changes backwards compatible? Please answer below:

Did you QA this? Could we deploy this straight to production? Please answer below:

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

[coderabbitai]

Walkthrough

Walkthrough

The update primarily focuses on enhancing data handling in the Apollo client configuration by introducing a new Fact object with specific key fields and refining the Query object to use modern JavaScript features for constructing the facts array. These changes aim to improve data management and query efficiency within the application.

Changes

File	Change Summary
lib/apollo.js	Added a new Fact object with keyFields set to ['id', 'type']. Updated the Query object to utilize spread operators and a map function to construct the facts array efficiently.

Assessment against linked issues

Objective	Addressed	Explanation
Resolve the "Stacked" filter issue on the statistics page by ensuring no data is shown when all filters are deselected. (#995)	❓	The changes in lib/apollo.js primarily focus on data structuring and retrieval rather than directly addressing the filter logic issue described in issue #995. Further investigation into other parts of the codebase handling filter behavior is necessary to determine if the issue has been resolved.

The modifications made in lib/apollo.js do not explicitly indicate a resolution to the filtering issue reported in issue #995. While the changes enhance data handling and query construction, they do not directly impact the behavior of filter toggling on the statistics page. Additional exploration of other code sections related to filter logic is required to ascertain if the issue has been effectively addressed.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 990128d and f9216bd.

Files selected for processing (1)

• lib/apollo.js (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• lib/apollo.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.