-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support other currencies #192
Conversation
e970b0c
to
f66a816
Compare
Overall looks pretty good. I'm pretty swamped with stuff but I'll try to take a closer look soon. I agree a dropdown would be a much better UX. |
I implemented it as a dropdown now. Also added currencies suggested by a user here: https://stacker.news/items/69184 Also fixed some errors if the user is not logged in yet and thus |
Nice job! I'll try to merge this soon |
I see there are conflicts and the dropdown has the same issue as described in #200. Will resolve conflicts and check dropdown scrollbars soon. |
My bad. Merged out of order. I plan to merge this PR and the other remaining tomorrow. I can fix myself if you don't have time. |
Haha, no worries. I actually like resolving conflicts. I used the Github GUI now. It is actually decent for small conflicts like these. I didn't check #200 however. Not sure if that needs a separate fix here or will be automatically fixed because it uses the same CSS (most likely) |
Hey! Thanks for your website, I have really fallen in love with it and visit it every day!
But I missed a user setting to choose the preferred currency, so I added it; open source ftw! 馃槃 (closes #103)
I have only added
EUR
, but other currencies which coinbase supports are easy to add. Just add it together with the symbol toCURRENCY_SYMBOLS
incomponents/price.js
.At first, I wanted to use a dropdown to choose the currency in the settings, but I didn't found a dropdown I could reuse, so I just went with a text input first.
Please tell me if you like it and if I should adapt anything 馃憤