Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to email signup page for newsletter in newsletter signature #737

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

SatsAllDay
Copy link
Contributor

Copy link
Member

@ekzyis ekzyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhh, I think this will also be included in the newsletter to the people who already signed up. So it might be confusing for these readers to find a signup link in the newsletter that people only receive when they sign up - as if they didn't signup already.

So maybe this is more something to only include in the SN post?

@SatsAllDay
Copy link
Contributor Author

Good point. Maybe I can add a CLI parameter to conditionally include this blurb? I'm not sure how @huumn runs this so I'm not sure the best way to facilitate dynamic content.

@huumn
Copy link
Member

huumn commented Jan 7, 2024

I'll just delete it when I copy it for the email. All good. Thanks!

@huumn huumn merged commit cb076ec into stackernews:master Jan 7, 2024
1 check passed
@SatsAllDay SatsAllDay deleted the newsletter-email-link branch January 7, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants