Format internal links as #<id>

[ekzyis]

This formats links like https://stacker.news/items/395051 to #395051

[huumn]

Excited about this one. I've been think a lot about #350 lately.

For this change, I think we'll want to handle two other cases:

1. referral links, because many folks use the copy link action
2. comment links using copy link which I changed here d14123c

So we'll want a regex that matches something that looks like this: https://stacker.news/items/<item id>[/r/<nym>][?commentId=<item id>]

[ekzyis]

With cad1258, this:

https://stacker.news/items/395051

https://stacker.news/items/395051foobar

https://stacker.news/items/395051/r/ekzyis

https://stacker.news/items/328193/r/ekzyis?commentId=395064

https://stacker.news/items/328193?commentId=395064&parentId=1241

gets formatted to:

[#395051](https://stacker.news/items/395051)

https://stacker.news/items/395051foobar

[#395051](https://stacker.news/items/395051/r/ekzyis)

[#328193](https://stacker.news/items/328193/r/ekzyis?commentId=395064)

[#328193](https://stacker.news/items/328193?commentId=395064&parentId=1241)

See https://regexr.com/7qola

Btw, I noticed that the _ in our name validator is unnecessary since underscores are included in the \w character class:

const nameValidator = string()
  .required('required')
  .matches(/^[\w_]+$/, 'only letters, numbers, and _')
  .max(32, 'too long')

[huumn]

Not a huge deal but shouldn't this [#328193](https://stacker.news/items/328193/r/ekzyis?commentId=395064) show the commentId, ie [#395064](https://stacker.news/items/328193/r/ekzyis?commentId=395064), given that's what that links to?

[ekzyis]

Not a huge deal but shouldn't this [#328193](https://stacker.news/items/328193/r/ekzyis?commentId=395064) show the commentId, ie [#395064](https://stacker.news/items/328193/r/ekzyis?commentId=395064), given that's what that links to?

Ah good point, I agree

[ekzyis]

Done in 3873cbb.

Also refactored the code. I realized we can leverage URL parsing using the URL constrcutor. No need for a complicated regexp. Also, the code now doesn't even need to care about the origin.

the power of good sleep lol

[huumn]

This change turns [this in my text for the url](https://stacker.news/items/328193) into [#328193](https://stacker.news/items/328193) which is probably not what you want. I think you just need to move the code block for this change to later in the function.

[ekzyis]

This change turns [this in my text for the url](https://stacker.news/items/328193) into [#328193](https://stacker.news/items/328193) which is probably not what you want. I think you just need to move the code block for this change to later in the function.

Good catch, fixed in c34c2a4