Monthly rewards #890
Merged
Monthly rewards #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huumn
commented
Feb 29, 2024
| (what === 'stackers' && (query.by === 'stacked' || !USER_SORTS.includes(query.by))) || | ||
| (what === 'territories' && (query.by === 'stacked' || !SUB_SORTS.includes(query.by))) || | ||
| (what === 'stackers' && (query.by === 'rewardability' || !USER_SORTS.includes(query.by))) || | ||
| (what === 'territories' && (query.by === 'stacking' || !SUB_SORTS.includes(query.by))) || | ||
| (['posts', 'comments'].includes(what) && (query.by === 'zaprank' || !ITEM_SORTS.includes(query.by)))) { |
There was a problem hiding this comment.
I also changed stacked to stacking and spent to spending ... I felt like it was clearer.
ekzyis
reviewed
Mar 2, 2024
| const UPVOTE_EACH_REWARD = 4.0 | ||
| const TOP_PERCENTILE = 33 | ||
| const TOTAL_UPPER_BOUND_MSATS = 1000000000 | ||
| const TOTAL_UPPER_BOUND_MSATS = 10000000000 |
There was a problem hiding this comment.
nitpick: good use case for underscore notation:
- 10000000000
+ 10_000_000_000| GROUP BY users.id | ||
| ORDER BY streak DESC, created_at ASC | ||
| OFFSET $3 | ||
| LIMIT ${LIMIT}`, ...range, decodedCursor.offset) | ||
| ).map( | ||
| u => u.hideFromTopUsers || u.hideCowboyHat ? null : u |
There was a problem hiding this comment.
Would be cool to not hide the own account; only show that you are hidden for others.
There was a problem hiding this comment.
True, but we'd need to indicate they are hidden for other people too (because they'd go to view it and wonder if their setting has been applied)
| percentile_cutoff INTEGER DEFAULT 33, | ||
| each_upvote_portion FLOAT DEFAULT 4.0, | ||
| each_item_portion FLOAT DEFAULT 4.0, | ||
| handicap_ids INTEGER[] DEFAULT '{616, 6030, 946, 4502}', |
There was a problem hiding this comment.
We exclude them in the earn job but it would've been nice to do here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are doing a monthly rewards experiment. To better support this so far we have:
TODO:
/rewards) for monthly rewards with more rewardable stackersearnjob logic