Don't hide self in top even if hidden #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unhides the own account in any user list. To not confuse stackers, it highlights that the account is still hidden for others using the anon icon:
Tested by looking which users are currently at the top in my db dump and then impersonating one of them. Did that via login with lightning and updating
users.pubkeyin their row with my pubkey and then login again.I only checked /top/stackers/forever and not the leaderboard since my leaderboard was empty locally but looking at the code, they all use the same code so I am pretty confident this will indeed just work™ for any user list.
This is the first PR to solve what @kerooke mentioned in Slack with showing users their MSM leaderboard rank even if they are outside of top 64 but this felt like the first of two steps to get there. This felt like a precursor since we most likely want to show the rank of any user, ignoring their privacy setting.
This would also solve some stackers removing their privacy setting just to look at their rank which is bad UX even though it might lead to funny encounters.