Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to avoid installing the libvirt daemon and/or client #44

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

markgoddard
Copy link
Member

@markgoddard markgoddard commented Dec 9, 2020

This may be useful where we want to use an existing libvirt daemon.

Also use virsh pool-build to create the backing directory for directory-based pools.

This may be useful where we want to use an existing libvirt daemon.
@markgoddard markgoddard self-assigned this Dec 9, 2020
This approach is cleaner, and doesn't assume that Ansible has access to the
pool's backing directory.
@markgoddard markgoddard marked this pull request as ready for review December 15, 2020 16:33
@markgoddard markgoddard merged commit 05a3470 into master Dec 16, 2020
@markgoddard markgoddard deleted the allow-skip-install branch December 16, 2020 09:23
openstack-mirroring pushed a commit to openstack/kayobe that referenced this pull request Dec 17, 2020
* Bump stackhpc.libvirt-host to v1.7.1. On seed-hypervisors installed
  using CentOS 8.2 or earlier, interaction with libvirt may fail due to
  libgcrypt being incompatible. See
  stackhpc/ansible-role-libvirt-host#42

* Bump MichaelRigart.interfaces to v1.9.2. The CentOS 8.3 cloud image
  includes an ifcfg-ens3-1 file. See
  michaelrigart/ansible-role-interfaces#93

* Previously a second libvirt daemon was installed by Tenks on the host,
  however changes in libvirt 6.0.0 to separate libvirtd into multiple
  daemons do not allow for customisation of the PID files used by the
  new daemons. This leads to a conflict between the container and host
  daemons. Update the Tenks config to use the containerised Nova libvirt
  daemon. This depends on a change to the stackhpc.libvirt-host role:
  stackhpc/ansible-role-libvirt-host#44

* Not CentOS 8.3 related, but tox jobs are now failing on python
  dependencies. Remove upper limits from docker and paramiko.

* Not CentOS 8.3 related, but Bifrost has enabled authentication by
  default. We are not ready to support this, so override it.

Story: 2008429
Task: 41378

Change-Id: Ie8fd965165e8d347d27528a2c16d0647e412ccdc
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Dec 17, 2020
* Update kayobe from branch 'master'
  to 4398856ec80ae765e805df9aab7d6f2105a34009
  - Fixes for CentOS 8.3
    
    * Bump stackhpc.libvirt-host to v1.7.1. On seed-hypervisors installed
      using CentOS 8.2 or earlier, interaction with libvirt may fail due to
      libgcrypt being incompatible. See
      stackhpc/ansible-role-libvirt-host#42
    
    * Bump MichaelRigart.interfaces to v1.9.2. The CentOS 8.3 cloud image
      includes an ifcfg-ens3-1 file. See
      michaelrigart/ansible-role-interfaces#93
    
    * Previously a second libvirt daemon was installed by Tenks on the host,
      however changes in libvirt 6.0.0 to separate libvirtd into multiple
      daemons do not allow for customisation of the PID files used by the
      new daemons. This leads to a conflict between the container and host
      daemons. Update the Tenks config to use the containerised Nova libvirt
      daemon. This depends on a change to the stackhpc.libvirt-host role:
      stackhpc/ansible-role-libvirt-host#44
    
    * Not CentOS 8.3 related, but tox jobs are now failing on python
      dependencies. Remove upper limits from docker and paramiko.
    
    * Not CentOS 8.3 related, but Bifrost has enabled authentication by
      default. We are not ready to support this, so override it.
    
    Story: 2008429
    Task: 41378
    
    Change-Id: Ie8fd965165e8d347d27528a2c16d0647e412ccdc
openstack-mirroring pushed a commit to openstack/kayobe that referenced this pull request Dec 21, 2020
* Bump stackhpc.libvirt-host to v1.7.1. On seed-hypervisors installed
  using CentOS 8.2 or earlier, interaction with libvirt may fail due to
  libgcrypt being incompatible. See
  stackhpc/ansible-role-libvirt-host#42

* Bump MichaelRigart.interfaces to v1.9.2. The CentOS 8.3 cloud image
  includes an ifcfg-ens3-1 file. See
  michaelrigart/ansible-role-interfaces#93

* Previously a second libvirt daemon was installed by Tenks on the host,
  however changes in libvirt 6.0.0 to separate libvirtd into multiple
  daemons do not allow for customisation of the PID files used by the
  new daemons. This leads to a conflict between the container and host
  daemons. Update the Tenks config to use the containerised Nova libvirt
  daemon. This depends on a change to the stackhpc.libvirt-host role:
  stackhpc/ansible-role-libvirt-host#44

* Not CentOS 8.3 related, but tox jobs are now failing on python
  dependencies. Remove upper limits from docker and paramiko.

This change also includes the following backport:

CI: add dummy1 port for seed upgrade and VM jobs

For some reason this configuration was omitted or incomplete in these
jobs. Without this configuration, Kayobe development configuration adds
eth1 to the breth1 bridge if it exists, or leaves the bridge without a
port otherwise. This can lead to network connectivity issues, if the IP
address of eth1 becomes inaccessible when it is added to breth1.

This change fixes the issue by ensuring that the dummy1 interface
exists, and configuring the aio network to add it to breth1 as a port,
instead of eth1.

Backport Change-Id: I47115e5d8d1fb448cb9e46dc43b56c64987e428b
(cherry picked from commit 0766df1)

Story: 2008429
Task: 41378

Change-Id: Ie8fd965165e8d347d27528a2c16d0647e412ccdc
(cherry picked from commit 4398856)
openstack-mirroring pushed a commit to openstack/kayobe that referenced this pull request Dec 21, 2020
* Bump stackhpc.libvirt-host to v1.7.1. On seed-hypervisors installed
  using CentOS 8.2 or earlier, interaction with libvirt may fail due to
  libgcrypt being incompatible. See
  stackhpc/ansible-role-libvirt-host#42

* Bump MichaelRigart.interfaces to v1.9.2. The CentOS 8.3 cloud image
  includes an ifcfg-ens3-1 file. See
  michaelrigart/ansible-role-interfaces#93

* Previously a second libvirt daemon was installed by Tenks on the host,
  however changes in libvirt 6.0.0 to separate libvirtd into multiple
  daemons do not allow for customisation of the PID files used by the
  new daemons. This leads to a conflict between the container and host
  daemons. Update the Tenks config to use the containerised Nova libvirt
  daemon. This depends on a change to the stackhpc.libvirt-host role:
  stackhpc/ansible-role-libvirt-host#44

* Not CentOS 8.3 related, but tox jobs are now failing on python
  dependencies due to the pip resolver. Remove upper limits from docker
  and paramiko. molecule is only required for the molecule tox
  environment, which is Python 2.

Also includes a backport of the following change:

Fix sphinx8 script used by pep8

We wrap doc8 to register the directives we use in our documentation.
Previously the 'app' argument was passed as None, however sphinx has
started to use the argument.

This change uses a mock object since we don't need to use the
application object.

Backported Change-Id: Id9e8d5f6d09f14d294cd493538780456f98c7dbe
(cherry picked from commit 2fcdff1)

Story: 2008429
Task: 41378

Change-Id: Ie8fd965165e8d347d27528a2c16d0647e412ccdc
(cherry picked from commit 4398856)
openstack-mirroring pushed a commit to openstack/kayobe that referenced this pull request Dec 22, 2020
* Bump stackhpc.libvirt-host to v1.7.1. On seed-hypervisors installed
  using CentOS 8.2 or earlier, interaction with libvirt may fail due to
  libgcrypt being incompatible. See
  stackhpc/ansible-role-libvirt-host#42

* Bump MichaelRigart.interfaces to v1.9.2. The CentOS 8.3 cloud image
  includes an ifcfg-ens3-1 file. See
  michaelrigart/ansible-role-interfaces#93

* Previously a second libvirt daemon was installed by Tenks on the host,
  however changes in libvirt 6.0.0 to separate libvirtd into multiple
  daemons do not allow for customisation of the PID files used by the
  new daemons. This leads to a conflict between the container and host
  daemons. Update the Tenks config to use the containerised Nova libvirt
  daemon. This depends on a change to the stackhpc.libvirt-host role:
  stackhpc/ansible-role-libvirt-host#44

* Not CentOS 8.3 related, but tox jobs are now failing on python
  dependencies. Remove upper limits from docker and paramiko. Update
  hacking which is requiring an old version of ansible-lint through the
  new pip dependency resolver (cherry picked from commit
  7b60585).

This also includes a backport of the following change:

CI: add dummy1 port for seed upgrade and VM jobs

For some reason this configuration was omitted or incomplete in these
jobs. Without this configuration, Kayobe development configuration adds
eth1 to the breth1 bridge if it exists, or leaves the bridge without a
port otherwise. This can lead to network connectivity issues, if the IP
address of eth1 becomes inaccessible when it is added to breth1.

This change fixes the issue by ensuring that the dummy1 interface
exists, and configuring the aio network to add it to breth1 as a port,
instead of eth1.

Backported Change-Id: I47115e5d8d1fb448cb9e46dc43b56c64987e428b
(cherry picked from commit 0766df1)

Depends-On: https://review.opendev.org/c/openstack/kayobe/+/767600

Story: 2008429
Task: 41378

Change-Id: Ie8fd965165e8d347d27528a2c16d0647e412ccdc
(cherry picked from commit 4398856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants