Enable FQCN debug output #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansible linting complains about:
1. Using the freeform version of debug
2. Not using the FQCN of the debug builtin
This PR addresses both issues, enabling output parsing when the
appliance Ansible task looks like this:
- ansible.builtin.debug:
var: outputs
vars:
outputs:
cluster_access_ip: "{{ cluster_floating_ip_address | default(None) }}"
delegate_to: localhost
JohnGarbutt
reviewed
Apr 17, 2024
| from azimuth_caas_operator.utils import cluster_type as cluster_type_utils | ||
| from azimuth_caas_operator.utils import image as image_utils | ||
| from azimuth_caas_operator.utils import k8s | ||
|
|
||
|
|
There was a problem hiding this comment.
I think the space changes are causing problems here. I think these need reverting please.
There was a problem hiding this comment.
Should be done in 63f25f6
JohnGarbutt
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on an Azimuth appliance, Ansible linting complains about:
This PR addresses both issues, enabling output parsing when the appliance Ansible task looks like this: