Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI workflow with updated slurm version to build images #1

Merged
merged 13 commits into from
Jun 23, 2023
Merged

Conversation

wtripp180901
Copy link
Contributor

No description provided.

@wtripp180901 wtripp180901 requested a review from sjpb June 21, 2023 14:31
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs some commented-out stuff deleted.

cache-from: type=local,src=/tmp/.buildx-cache
cache-to: type=local,dest=/tmp/.buildx-cache-new,mode=max

#- name: Verify push to GHCR
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete commented-out block

#- name: Verify push to GHCR
# run: docker inspect ${{ fromJSON(steps.image-meta.outputs.json).tags[1] }}

#- name: Test image by running help
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete commented-out block, this is from the stuff we copied and not at all relevant here.

@wtripp180901
Copy link
Contributor Author

Comments should all have been removed

@sjpb sjpb self-requested a review June 23, 2023 15:06
@sjpb sjpb merged commit 43e0338 into master Jun 23, 2023
1 check passed
@sjpb sjpb deleted the actions branch June 23, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants